[webkit-reviews] review granted: [Bug 79918] [GTK] Add WebKitWebView::console-message signal to WebKit2 GTK+ API : [Attachment 174123] Updated patch

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 79918: [GTK] Add WebKitWebView::console-message signal to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=79918

Attachment 174123: Updated patch
https://bugs.webkit.org/attachment.cgi?id=174123&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=174123&action=review


> Source/WebKit2/UIProcess/API/gtk/WebKitConsoleMessage.h:39
> + * @WEBKIT_CONSOLE_MESSAGE_SOURCE_NETWORK: Message produced by WebSockets.

Wondering if it would make sense to use WEBSOCKETS instead of NETWORK here, but
I guess using NETWORK makes this more future-proof, as in, it could be used for
other features that deal with network connections, even though that would mean
a slight change in behaviour, meaning it would no longer mean websockets.

> Source/WebKit2/UIProcess/API/gtk/WebKitUIClient.cpp:161
> +static void addMessageToConsole(WKPageRef page, WKMessageSourceType source,
WKMessageLevelType level, WKStringRef message, unsigned lineNumber, WKStringRef
sourceID, const void* clientInfo)

The build fails, apparently we should use WebCore::MessageSource,
WebCore::MessageType, and WebCore::MessageLevel here.