[webkit-reviews] review denied: [Bug 100070] Add canvas blending modes using Core Graphics : [Attachment 178335] Added QT testexpectations file

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has denied  review:
Bug 100070: Add canvas blending modes using Core Graphics
https://bugs.webkit.org/show_bug.cgi?id=100070

Attachment 178335: Added QT testexpectations file
https://bugs.webkit.org/attachment.cgi?id=178335&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=178335&action=review


> Source/WebCore/ChangeLog:14
> +		  canvas/philip/tests/2d.composite.canvas.darken.html

Please don't add new tests to the test suite from Philip, as long as they are
not official part of the suite.

> Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp:1755
> +	   } else

Alignment problem + missing brace.

> LayoutTests/canvas/philip/tests/2d.composite.canvas.color-burn.html:25
> +_assertPixelApprox(canvas, 50,25, 110,255,37,223, "50,25", "110,255,37,223",
5);

We actually have our own test suite for this. Can you take a look in this
instead? Makes it easier to maintain. Or you start writing W3C Testharness.js
tests.

> LayoutTests/canvas/philip/tests/2d.composite.canvas.color-expected.txt:1
> +Passed

This is not enough on information. It should have a description what the test
is testing. See other tests outside the test suite from Philip.