[webkit-reviews] review granted: [Bug 104434] Make ninja the default build system for build-webkit --chromium : [Attachment 178344] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 104434: Make ninja the default build system for build-webkit --chromium
https://bugs.webkit.org/show_bug.cgi?id=104434

Attachment 178344: Patch
https://bugs.webkit.org/attachment.cgi?id=178344&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=178344&action=review


The patch looks good to me. I noticed some very minor spelling nits. As you
mentioned in comment 2, we should wait until next week to land this patch so as
to give people an opportunity to digest the webkit-dev email and provide
feedback.

> Tools/ChangeLog:3
> +	   Make ninja the default build system for build-webkit --chromium

Nit: ninja => Ninja

The word "ninja" appears five more times as a proper noun in this patch.

> Tools/ChangeLog:9
> +	   as their default build system instead of the native
Xcode/VisualStudio/Make.

Nit: VisualStudio => Visual Studio

> Tools/ChangeLog:10
> +	   This change makes ninja the default for developers as well as all
chromium webkit bots.

Nit: chromium => Chromium