[webkit-reviews] review granted: [Bug 104312] Shrink the size of NodeRareData by moving pointers into separate objects : [Attachment 178139] Moved new classes into NodeRareData

[bugzilla-daemon at webkit.org]

Andreas Kling <akling at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 104312: Shrink the size of NodeRareData by moving pointers into separate
objects
https://bugs.webkit.org/show_bug.cgi?id=104312

Attachment 178139: Moved new classes into NodeRareData
https://bugs.webkit.org/attachment.cgi?id=178139&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=178139&action=review


Great, r=me.

> Source/WebCore/dom/NodeRareData.h:64
> +	   if (m_childNodeList)
> +	       return m_childNodeList;
> +	   RefPtr<ChildNodeList> list = ChildNodeList::create(node);
> +	   m_childNodeList = list.get();
> +	   return list.release();

Would read slightly nicer as:

if (!m_childNodeList)
    m_childNodeList = ChildNodeList::create(node);
return m_childNodeList;