[webkit-reviews] review granted: [Bug 103796] [chromium] ImageDecodingStore should cache partially decoded images : [Attachment 178292] Patch

[bugzilla-daemon at webkit.org]

Stephen White <senorblanco at chromium.org> has granted Hin-Chung Lam
<hclam at google.com>'s request for review:
Bug 103796: [chromium] ImageDecodingStore should cache partially decoded images
https://bugs.webkit.org/show_bug.cgi?id=103796

Attachment 178292: Patch
https://bugs.webkit.org/attachment.cgi?id=178292&action=review

------- Additional Comments from Stephen White <senorblanco at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=178292&action=review


OK.  The logic still seems a bit complex, but perhaps that can be cleaned up
later.	r=me

> Source/WebCore/platform/graphics/chromium/ImageFrameGenerator.cpp:191
> +	       *decoder = m_imageDecoderFactory->create().leakPtr();

I wonder if this function (and others) should take an OwnPtr<ImageDecoder>*
instead?  Then you wouldn't have to call leakPtr() here.