[webkit-reviews] review granted: [Bug 104406] JSC should scale the optimization threshold for a code block according to the cost of compiling it : [Attachment 178289] the patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 104406: JSC should scale the optimization threshold for a code block
according to the cost of compiling it
https://bugs.webkit.org/show_bug.cgi?id=104406

Attachment 178289: the patch
https://bugs.webkit.org/attachment.cgi?id=178289&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=178289&action=review


r=me, please fix comments before landing.

> Source/JavaScriptCore/dfg/DFGCapabilities.h:48
> +bool mightCompileEval(CodeBlock* codeBlock);
> +bool mightCompileProgram(CodeBlock* codeBlock);
> +bool mightCompileFunctionForCall(CodeBlock* codeBlock);
> +bool mightCompileFunctionForConstruct(CodeBlock* codeBlock);
> +bool mightInlineFunctionForCall(CodeBlock* codeBlock);
> +bool mightInlineFunctionForConstruct(CodeBlock* codeBlock);
>  

Style bot is right here, for once.