[webkit-reviews] review granted: [Bug 104405] webkit-patch print-expectations doesn't work right for platforms w/ shared expectations : [Attachment 178287] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 104405: webkit-patch print-expectations doesn't work right for platforms w/
shared expectations
https://bugs.webkit.org/show_bug.cgi?id=104405

Attachment 178287: Patch
https://bugs.webkit.org/attachment.cgi?id=178287&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=178287&action=review


Rs=me

> Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:70
> +	   # FIXME: This won't work if multiple ports share a TestExpectations
file but support different modifiers in the file.

Should we be asserting?