[webkit-reviews] review granted: [Bug 104259] Fix webgl-depth-texture.html to match the test expectation : [Attachment 178015] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 7 15:00:38 PST 2012


Kenneth Russell <kbr at google.com> has granted Kalyan
<kalyan.kondapally at intel.com>'s request for review:
Bug 104259: Fix webgl-depth-texture.html to match the test expectation
https://bugs.webkit.org/show_bug.cgi?id=104259

Attachment 178015: patch
https://bugs.webkit.org/attachment.cgi?id=178015&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
The basic problem seems to be that Intel's driver reports the framebuffer as
complete after adding only the depth or depth/stencil texture, and the test
only asserts that the FBO is complete if it was incomplete with just that
attachment. The change to the test matches the current expectations for all the
ports, so it seems OK. I will take care of upstreaming this change to the
Khronos WebGL repo. r=me


More information about the webkit-reviews mailing list