[webkit-reviews] review granted: [Bug 98921] MutationRecord addedNodes/removedNodes should never be null : [Attachment 178276] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 7 14:30:22 PST 2012


Ryosuke Niwa <rniwa at webkit.org> has granted Adam Klein <adamk at chromium.org>'s
request for review:
Bug 98921: MutationRecord addedNodes/removedNodes should never be null
https://bugs.webkit.org/show_bug.cgi?id=98921

Attachment 178276: Patch
https://bugs.webkit.org/attachment.cgi?id=178276&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=178276&action=review


> Source/WebCore/dom/MutationRecord.cpp:92
> +	       Vector<RefPtr<Node> > emptyVector;
> +	       nodeList = StaticNodeList::adopt(emptyVector);

You would add StaticNodeList::create() to avoid swap.


More information about the webkit-reviews mailing list