[webkit-reviews] review granted: [Bug 103067] Keyboard caret movement in textarea with RTL Override Character can make tab unresponsive : [Attachment 177825] updated base on Niwa's review

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Yi Shen <max.hong.shen at gmail.com>'s
request for review:
Bug 103067: Keyboard caret movement in textarea with RTL Override Character can
make tab unresponsive
https://bugs.webkit.org/show_bug.cgi?id=103067

Attachment 177825: updated base on Niwa's review
https://bugs.webkit.org/attachment.cgi?id=177825&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=177825&action=review


> Source/WebCore/editing/VisiblePosition.cpp:148
> -		   InlineBox* prevBox = box->prevLeafChild();
> +		   InlineBox* prevBox = box->prevLeafChildIgnoringLineBreak();

Looks much better!

> LayoutTests/editing/selection/move-by-character-crash-test-textarea.html:11
> +    var test = document.getElementById("test_move_by_character");

Please use camelCase.