[webkit-reviews] review denied: [Bug 104366] Make order iterator member stack allocated in RenderFlexibleBox : [Attachment 178209] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has denied Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 104366: Make order iterator member stack allocated in RenderFlexibleBox
https://bugs.webkit.org/show_bug.cgi?id=104366

Attachment 178209: Patch
https://bugs.webkit.org/attachment.cgi?id=178209&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=178209&action=review


> Source/WebCore/ChangeLog:14
> +	   (WebCore::RenderFlexibleBox::baselinePosition): Make it non const
> +	   because the order iterator is modified.

This doesn't work because now it's not actually overriding the parent class's
virtual baselinePosition method. constness has to match. I'm not what you
should do instead. :(