[webkit-reviews] review denied: [Bug 104240] [CMake] Add CMake style checker : [Attachment 178187] Patch

[bugzilla-daemon at webkit.org]

Laszlo Gombos <laszlo.gombos at webkit.org> has denied Halton Huo
<halton.huo at gmail.com>'s request for review:
Bug 104240: [CMake] Add CMake style checker
https://bugs.webkit.org/show_bug.cgi?id=104240

Attachment 178187: Patch
https://bugs.webkit.org/attachment.cgi?id=178187&action=review

------- Additional Comments from Laszlo Gombos <laszlo.gombos at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=178187&action=review


Almost there, but I think the patch itself should pass the style check; r- for
that.

> Tools/Scripts/webkitpy/style/checkers/cmake_unittest_input.cmake:1
> +# This file is sample input for cmake_unittest.py and includes below
problems:

It would be better to include the test input inside cmake_unittest.py and not
as a separate file - not necessary as one big buffer but as a serious of unit
tests like it is done for the other checkers (see for example
changelog_unittest.py). This would also avoid the problem that your negative
tests in the cmake_unittest*.cmake fail on the style check.