[webkit-reviews] review granted: [Bug 101116] Text nodes in shadow roots don't inherit style properly : [Attachment 178180] Patch

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Takashi Sakamoto
<tasak at google.com>'s request for review:
Bug 101116: Text nodes in shadow roots don't inherit style properly
https://bugs.webkit.org/show_bug.cgi?id=101116

Attachment 178180: Patch
https://bugs.webkit.org/attachment.cgi?id=178180&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=178180&action=review


>> Source/WebCore/css/StyleResolver.cpp:1781
>> +PassRefPtr<RenderStyle> StyleResolver::defaultStyleForElement()
> 
> defaultStyleForNode() ? Text are not Elements.

In this context, he's just initializing defaults for element style resolution.

>> Source/WebCore/css/StyleResolver.cpp:1794
>> +PassRefPtr<RenderStyle> StyleResolver::styleForText(Node* textNode)
> 
> This should just take Text* and you can remove the isTextNode() assert below.


Good point!

>> Source/WebCore/dom/NodeRenderingContext.cpp:285
>> +	if (UNLIKELY(resetStyleInheritance()))
> 
> Does the UNLIKELY actually make a difference? ojan has said it doesn't
usually matter (and produces identical assembly).

It's called UNLIKELY, because it is unlikely to have any effect on your code.