[webkit-reviews] review denied: [Bug 104369] [GTK] Expose HitTestResult::scrollbar() condition in API : [Attachment 178221] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 7 08:27:20 PST 2012


Carlos Garcia Campos <cgarcia at igalia.com> has denied Eduardo Lima Mitev
<elima at igalia.com>'s request for review:
Bug 104369: [GTK] Expose HitTestResult::scrollbar() condition in API
https://bugs.webkit.org/show_bug.cgi?id=104369

Attachment 178221: patch
https://bugs.webkit.org/attachment.cgi?id=178221&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=178221&action=review


Patch looks great, thanks! Setting r- just because it doesn't include unit
tests. You can modify WebKitWebView/mouse-target test to check it. Use a form
control containing scrollbars, because main scrollbars won't work due to bug
#99591.

> Source/WebKit2/Shared/WebHitTestResult.h:55
> +	   bool isOverScrollbar;

I would use isScrollbar.

> Source/WebKit2/Shared/WebHitTestResult.h:87
> +	       , isOverScrollbar(hitTestResult.scrollbar())

Ditto.


More information about the webkit-reviews mailing list