[webkit-reviews] review requested: [Bug 103520] [EFL][GTK] context-menu-suggestions.html fails : [Attachment 178211] proposed patch - right click makes selection on misspelled word

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 7 06:02:56 PST 2012


Grzegorz Czajkowski <g.czajkowski at samsung.com> has asked  for review:
Bug 103520: [EFL][GTK] context-menu-suggestions.html fails
https://bugs.webkit.org/show_bug.cgi?id=103520

Attachment 178211: proposed patch - right click makes selection on misspelled
word
https://bugs.webkit.org/attachment.cgi?id=178211&action=review

------- Additional Comments from Grzegorz Czajkowski <g.czajkowski at samsung.com>
This patch is based on Chromium implementation. Tested for 
 - WebKi2-Gtk's MiniBrowser as it implements spelling and context menu
features.
 - WebKit2-EFL layout tests.

TODO:
 - context-menu-suggestions.html is still failing for WebKit-GTK, I am
investigating it
 - I am wondering whether this policy could be applied to all Unix WebKit ports

 - I am not able to test how it influences Chromium as this change might make
duplication/conflict with their original code. I'd be nice if you could express
your suggestions about it.


More information about the webkit-reviews mailing list