[webkit-reviews] review granted: [Bug 104074] Web Inspector: Add command for dispatching mouse events : [Attachment 178092] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Ken Kania
<kkania at chromium.org>'s request for review:
Bug 104074: Web Inspector: Add command for dispatching mouse events
https://bugs.webkit.org/show_bug.cgi?id=104074

Attachment 178092: Patch
https://bugs.webkit.org/attachment.cgi?id=178092&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=178092&action=review


> Source/WebCore/inspector/Inspector.json:3291
> +		       { "name": "button", "type": "string", "enum": ["none",
"left", "middle", "right"], "optional": true, "description": "Mouse button
(default: \"none\")." },

What would be a reason for sending button=none or clickCount=0? Does it make
any sense?

> Source/WebCore/inspector/Inspector.json:3293
> +		       { "name": "x", "type": "integer", "description": "X
coordinate of the event relative to the frame's viewport."},

It is always relative to the _main_ frame, the description should reflect this.
Alternatively we may pass frame id to specify in which frame the event should
be dispatched.

> Source/WebCore/inspector/InspectorInputAgent.cpp:101
> +    else if (type == "mouseReleased")

I think we should teach CodeGeneratorInspector.py to generate string values for
enum elements to  avoid using constant values like this. But this is not
directly related to this change and should be addressed separately.