[webkit-reviews] review granted: [Bug 104275] Leaf nodes should use parent tree scope : [Attachment 178065] Patch

[bugzilla-daemon at webkit.org]

Hajime Morrita <morrita at google.com> has granted Elliott Sprehn
<esprehn at chromium.org>'s request for review:
Bug 104275: Leaf nodes should use parent tree scope
https://bugs.webkit.org/show_bug.cgi?id=104275

Attachment 178065: Patch
https://bugs.webkit.org/attachment.cgi?id=178065&action=review

------- Additional Comments from Hajime Morrita <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=178065&action=review


This is clever. cq- since this seems incompatible to your another patch.

> Source/WebCore/dom/Document.h:1557
> +    if (!isContainerNode() && parentNode())

This can be tuned a bit more
- parentNode() has one flag check so the result better be stored.
- if !isContainerNode(), it cannot be in shadow, so the tree scope is always
document.