[webkit-reviews] review granted: [Bug 103342] [EFL][WK2] Add ewk_settings APIs for text autosizing : [Attachment 176138] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 6 18:00:02 PST 2012


Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Jaehun Lim
<ljaehun.lim at samsung.com>'s request for review:
Bug 103342: [EFL][WK2] Add ewk_settings APIs for text autosizing
https://bugs.webkit.org/show_bug.cgi?id=103342

Attachment 176138: Patch
https://bugs.webkit.org/attachment.cgi?id=176138&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=176138&action=review


>> Source/WebKit2/UIProcess/API/efl/ewk_settings.cpp:354
>> +	EINA_SAFETY_ON_NULL_RETURN_VAL(settings, false);
> 
> I think we don't need to keep this line when disabling TEXT_AUTOSIZING

The line is correct and people could give a null pointer.

I say leave it


More information about the webkit-reviews mailing list