[webkit-reviews] review granted: [Bug 104314] Throw away StyleResolvers that haven't been used for a long time. : [Attachment 178104] Proposed patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Andreas Kling <akling at apple.com>'s
request for review:
Bug 104314: Throw away StyleResolvers that haven't been used for a long time.
https://bugs.webkit.org/show_bug.cgi?id=104314

Attachment 178104: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=178104&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=178104&action=review


> Source/WebCore/dom/Document.cpp:4446
> +    // Throttle the calls to startOneShot() a bit since it's non-trivial on
some platforms.
> +    if (now > m_lastStyleResolverAccessTime + 5) {
> +	   m_styleResolverThrowawayTimer.startOneShot(60);
> +	   m_lastStyleResolverAccessTime = now;
> +    }

Please use named constants.