[webkit-reviews] review denied: [Bug 89261] [CSS Exclusions] Floats should respect shape-inside on exclusions : [Attachment 176040] Updated Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Dec 6 14:47:22 PST 2012
Dave Hyatt <hyatt at apple.com> has denied Bem Jones-Bey <bjonesbe at adobe.com>'s
request for review:
Bug 89261: [CSS Exclusions] Floats should respect shape-inside on exclusions
https://bugs.webkit.org/show_bug.cgi?id=89261
Attachment 176040: Updated Patch
https://bugs.webkit.org/attachment.cgi?id=176040&action=review
------- Additional Comments from Dave Hyatt <hyatt at apple.com>
It feels weird to me to patch this spot. We already have functions that tell
you the left and right offsets for content at a given block offset.... why
would you not just patch them?
Basically I'm wondering why you didn't patch at a lower level, e.g.,
logicalLeftOffsetForContent.
More information about the webkit-reviews
mailing list