[webkit-reviews] review granted: [Bug 49246] Main resource should be cached in the memory cache : [Attachment 177839] Address abarth's comments

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted  review:
Bug 49246: Main resource should be cached in the memory cache
https://bugs.webkit.org/show_bug.cgi?id=49246

Attachment 177839: Address abarth's comments
https://bugs.webkit.org/attachment.cgi?id=177839&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=177839&action=review


r+'d back since this is mainly a naming concern. The current MainResourceLoader
still seems like an odd type (besides the name) with ill-defined purpose so I
think this is going to need more work.

> Source/WebCore/loader/MainResourceLoader.cpp:637
> +    if (m_substituteData.isValid())
> +	   handleSubstituteDataLoadSoon(request);
> +    else {
> +	   DEFINE_STATIC_LOCAL(ResourceLoaderOptions, mainResourceLoadOptions,

Looks like this could do early return.