[webkit-reviews] review granted: [Bug 103724] Port SharedTimerWin.cpp to WinCE : [Attachment 176926] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 103724: Port SharedTimerWin.cpp to WinCE
https://bugs.webkit.org/show_bug.cgi?id=103724

Attachment 176926: Patch
https://bugs.webkit.org/attachment.cgi?id=176926&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=176926&action=review


Looks good to me. r=me.

> Source/WebCore/platform/win/SharedTimerWin.cpp:133
> +#if OS(WINCE)

It's too bad these have to be different. I guess there's not much choice here,
since the API doesn't existing in WinCE.

> Source/WebCore/platform/win/SharedTimerWin.cpp:227
> +#if !OS(WINCE)

This conditional would be unnecessary if you declared timer outside your
earlier !OS(WINCE) declarations at top.