[webkit-reviews] review requested: [Bug 104279] [Mac] Add Build Phase to Check Headers for Inappropriate Macros (Platform.h macros) : [Attachment 178049] [PATCH] Part 2: Run the Script as an Xcode Build Phase

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 6 11:41:32 PST 2012


Joseph Pecoraro <joepeck at webkit.org> has asked	for review:
Bug 104279: [Mac] Add Build Phase to Check Headers for Inappropriate Macros
(Platform.h macros)
https://bugs.webkit.org/show_bug.cgi?id=104279

Attachment 178049: [PATCH] Part 2: Run the Script as an Xcode Build Phase
https://bugs.webkit.org/attachment.cgi?id=178049&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
Build phase in each looks like: (note we are just testing public headers right
now)

>    if [ "${ACTION}" = "installhdrs" ]; then
>	 exit 0;
>    fi
>
>    if [ -f
../../Tools/Scripts/check-for-inappropriate-macros-in-external-headers ]; then
>	 ../../Tools/Scripts/check-for-inappropriate-macros-in-external-headers
Headers || exit $?
>    fi


More information about the webkit-reviews mailing list