[webkit-reviews] review requested: [Bug 104279] [Mac] Add Build Phase to Check Headers for Inappropriate Macros (Platform.h macros) : [Attachment 178047] [PATCH] Part 1: Add script check-for-inappropriate-macros-in-external-headers
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Dec 6 11:39:47 PST 2012
Joseph Pecoraro <joepeck at webkit.org> has asked for review:
Bug 104279: [Mac] Add Build Phase to Check Headers for Inappropriate Macros
(Platform.h macros)
https://bugs.webkit.org/show_bug.cgi?id=104279
Attachment 178047: [PATCH] Part 1: Add script
check-for-inappropriate-macros-in-external-headers
https://bugs.webkit.org/attachment.cgi?id=178047&action=review
------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
Adds another ruby script and tests. The existing check-* scripts are mostly
ruby. None had tests so I added a webkitruby dir and tests to mirror webkitperl
and webkitpython.
Running tests looks like:
shell> ./Tools/Scripts/test-webkitruby
Testing: Tools/Scripts/check-for-inappropriate-macros-in-external-headers
PASS - test_good_fake_data
PASS - test_bad_fake_data
More information about the webkit-reviews
mailing list