[webkit-reviews] review denied: [Bug 49246] Main resource should be cached in the memory cache : [Attachment 177839] Address abarth's comments

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has denied  review:
Bug 49246: Main resource should be cached in the memory cache
https://bugs.webkit.org/show_bug.cgi?id=49246

Attachment 177839: Address abarth's comments
https://bugs.webkit.org/attachment.cgi?id=177839&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=177839&action=review


The patch is hard to follow partly due to general messiness of the loader code
and also because it is not clear what the end state looks like (since it
doesn't enable caching). It is sad that we haven't made much progress in
refactoring the code before attempting this. At minimum it seems to me that we
at least should get the layering right.

> Source/WebCore/loader/MainResourceLoader.cpp:372
> -void MainResourceLoader::didReceiveResponse(const ResourceResponse& r)
> +void MainResourceLoader::responseReceived(CachedResource* resource, const
ResourceResponse& r)

CachedResource is a higher level concept than ResourceLoader. Making the latter
depend on the former seems architecturally wrong.