[webkit-reviews] review granted: [Bug 103327] [CSS Exclusions] Add support for computing the first included interval position. : [Attachment 177911] Patch

[bugzilla-daemon at webkit.org]

Levi Weintraub <leviw at chromium.org> has granted Hans Muller
<giles_joplin at yahoo.com>'s request for review:
Bug 103327: [CSS Exclusions] Add support for computing the first included
interval position.
https://bugs.webkit.org/show_bug.cgi?id=103327

Attachment 177911: Patch
https://bugs.webkit.org/attachment.cgi?id=177911&action=review

------- Additional Comments from Levi Weintraub <leviw at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=177911&action=review


Okay.

> Source/WebCore/rendering/RenderBlockLineLayout.cpp:1468
> +// Before restarting the layout loop with a new logicalHeight, remove all
floats that were added and reset the resolver.
> +inline const InlineIterator&
RenderBlock::restartLayoutRunsAndFloatsInRange(LayoutUnit oldLogicalHeight,
LayoutUnit newLogicalHeight,  FloatingObject* lastFloatFromPreviousLine,
InlineBidiResolver& resolver,  const InlineIterator& oldEnd)

So much better to see this functionality get a descriptive name.