[webkit-reviews] review granted: [Bug 104164] [Qt][Mac] Fix libxslt and libxml2 config tests : [Attachment 177820] Patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has granted Andras Becsi
<abecsi at webkit.org>'s request for review:
Bug 104164: [Qt][Mac] Fix libxslt and libxml2 config tests
https://bugs.webkit.org/show_bug.cgi?id=104164

Attachment 177820: Patch
https://bugs.webkit.org/attachment.cgi?id=177820&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=177820&action=review


r=me with a small change before landing :)

> Tools/qmake/config.tests/libxslt/libxslt.pro:3
> +LIBS += -lxslt

I think the LIBS line should go into the mac scope, no? At least if we're using
pkg-config we should not be doing LIBS += but solely rely on what pkg-config
gives us.

Same in libxml2.pro