[webkit-reviews] review denied: [Bug 104103] Implement add64 for ARM traditional assembler after r136601 : [Attachment 177742] Patch

[bugzilla-daemon at webkit.org]

Zoltan Herczeg <zherczeg at webkit.org> has denied Gabor Ballabas
<gaborb at inf.u-szeged.hu>'s request for review:
Bug 104103: Implement add64 for ARM traditional assembler after r136601
https://bugs.webkit.org/show_bug.cgi?id=104103

Attachment 177742: Patch
https://bugs.webkit.org/attachment.cgi?id=177742&action=review

------- Additional Comments from Zoltan Herczeg <zherczeg at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=177742&action=review


> Source/JavaScriptCore/assembler/MacroAssemblerARM.h:905
> +	   if (imm.m_value <= 0xff)
> +	       m_assembler.adds(ARMRegisters::S0, ARMRegisters::S0,
ARMAssembler::getOp2Byte(imm.m_value));
> +	   else {
> +	       m_assembler.adds(ARMRegisters::S0, ARMRegisters::S0,
m_assembler.getImm(imm.m_value, ARMRegisters::S1));
> +	       move(TrustedImmPtr(address.m_ptr), ARMRegisters::S1);
> +	   }

This is not how we do at the moment. This should be a simple:

m_assembler.adds(dest, dest, m_assembler.getImm(imm.m_value,
ARMRegisters::S0));