[webkit-reviews] review denied: [Bug 104085] Fix broken WinCE build due to call to add64 in JIT.cpp : [Attachment 177666] Patch

[bugzilla-daemon at webkit.org]

Patrick R. Gansterer <paroga at paroga.com> has denied Vivek Galatage
<vivek.vg at samsung.com>'s request for review:
Bug 104085: Fix broken WinCE build due to call to add64 in JIT.cpp
https://bugs.webkit.org/show_bug.cgi?id=104085

Attachment 177666: Patch
https://bugs.webkit.org/attachment.cgi?id=177666&action=review

------- Additional Comments from Patrick R. Gansterer <paroga at paroga.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=177666&action=review


> Source/JavaScriptCore/ChangeLog:9
> +	   This call should be under the #if USE(JSVALUE64) guard as its not
implemented in WinCE MacroAssemblerARM.cpp

This has _nothing_ to do with WinCE. It's a "problem" of the traditional ARM
MacroAssembler.
Correct way to fix this is to implement add64() in the MacroAssembler.
Usually the szeged guys maintain the traditional ARM (e.g.
https://trac.webkit.org/changeset/135610).