[webkit-reviews] review denied: [Bug 103860] [WK2][EFL] Add ewk API for creating a view with legacy behavior : [Attachment 177192] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has denied KyungTae Kim
<ktf.kim at samsung.com>'s request for review:
Bug 103860: [WK2][EFL] Add ewk API for creating a view with legacy behavior
https://bugs.webkit.org/show_bug.cgi?id=103860

Attachment 177192: Patch
https://bugs.webkit.org/attachment.cgi?id=177192&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=177192&action=review


> Source/WebKit2/UIProcess/API/efl/ewk_view.h:342
>  EAPI Evas_Object *ewk_view_smart_add(Evas *e, Evas_Smart *smart, Ewk_Context
*context);
> +EAPI Evas_Object *ewk_view_smart_add_with_legacy_behavior(Evas *e,
Evas_Smart *smart, Ewk_Context *context);

We decided to not expose these things publically.

> Tools/MiniBrowser/efl/main.c:1062
> -    if (legacy_behavior_enabled) {
> -	   // Use raw WK2 api to create a view using legacy mode.
> -	   window->ewk_view = (Evas_Object*)WKViewCreate(evas, 0, 0);
> -    } else {
> -	   Evas_Smart *smart = evas_smart_class_new(&ewkViewClass->sc);
> +

MiniBrowser is a development tool. There is no problem using some internal API
for the sake of being able to improve debugging some cases.

The API is internal, it will not be documented, and even if people find it and
use it, we have no guarantees it will stay there or not change behavior. That
is fine.