[webkit-reviews] review granted: [Bug 104230] [V8] Implement v8StringWithoutIsolate() : [Attachment 177955] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 6 00:32:49 PST 2012


Adam Barth <abarth at webkit.org> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 104230: [V8] Implement v8StringWithoutIsolate()
https://bugs.webkit.org/show_bug.cgi?id=104230

Attachment 177955: Patch
https://bugs.webkit.org/attachment.cgi?id=177955&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=177955&action=review


Same comment about using the word "deprecated"

> Source/WebCore/bindings/v8/Dictionary.cpp:105
> +    ASSERT(m_isolate);

Oh, it looks like we do have an m_isolate for Dictionary.  We should use that
in the integer patch.


More information about the webkit-reviews mailing list