[webkit-reviews] review granted: [Bug 104220] [V8] Implement v8IntegerWithoutIsolate(int i) : [Attachment 177956] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 104220: [V8] Implement v8IntegerWithoutIsolate(int i)
https://bugs.webkit.org/show_bug.cgi?id=104220

Attachment 177956: Patch
https://bugs.webkit.org/attachment.cgi?id=177956&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=177956&action=review


You might also consider the name deprecatedV8Integer to inform people writing
future patches that they shouldn't add more callers of this function.

> Source/WebCore/bindings/v8/Dictionary.cpp:300
> -	   v8::Local<v8::Value> indexedValue = v8Array->Get(v8Integer(i));
> +	   v8::Local<v8::Value> indexedValue =
v8Array->Get(v8IntegerWithoutIsolate(i));

We should be able to store the isolate in a member variable of Dictionary. 
Code isn't allowed to hold on to Dictionaries past the call frame in which they
receive them.