[webkit-reviews] review granted: [Bug 104219] Page popup should align to the right when the anchor element is rtl : [Attachment 177954] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has granted Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 104219: Page popup should align to the right when the anchor element is rtl
https://bugs.webkit.org/show_bug.cgi?id=104219

Attachment 177954: Patch
https://bugs.webkit.org/attachment.cgi?id=177954&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=177954&action=review


> Source/WebCore/ChangeLog:15
> +	   (setWindowRect): If the window is hidden we want to move first then
resize so the popup doesn't flicker.
> +	   (isWindowHidden): Returns true if the window is hidden using
hideWindow().

nit: These changes look unrelated to the RTL issue.

> Source/WebCore/Resources/pagepopups/pickerCommon.js:172
> +	   var isHidden = isWindowHidden();
> +	   if (!isHidden)
> +	       window.resizeTo(rect.width, rect.height);
>	   window.moveTo(rect.x - window.screen.availLeft, rect.y -
window.screen.availTop);
> -	   window.resizeTo(rect.width, rect.height);
> +	   if (isHidden)
> +	       window.resizeTo(rect.width, rect.height);

nit: it's ok to write duplicated line to improve readability.

if (isWindowHidden()) {
    window.moveTo(...);
    window.resizeTo(...);
} else {
    window.resizeTo(...);
    window.moveTo(...);
}