[webkit-reviews] review denied: [Bug 103704] [EFL][WK2] Implement Accelerated2DCanvas on WK2 Efl port : [Attachment 177930] Patch

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam at webkit.org> has denied Kyungjin Kim
<gen.kim at samsung.com>'s request for review:
Bug 103704: [EFL][WK2] Implement Accelerated2DCanvas on WK2 Efl port
https://bugs.webkit.org/show_bug.cgi?id=103704

Attachment 177930: Patch
https://bugs.webkit.org/attachment.cgi?id=177930&action=review

------- Additional Comments from Noam Rosenthal <noam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=177930&action=review


I still don't get the point of accelerated canvas in coordinated graphics
without graphics surfaces, and it's still not explained.

> Source/WebCore/ChangeLog:11
> +	   for both cases using GRAPHICS_SURFACE and no GRAPHICS_SURFACE
because it is not enabled by default in EFL currently.

This is a strange reasoning to implement a non-GraphicsSurface fallback.
There is already a fallback - non-accelerated 2d canvas. Why have another
fallback that uses some sort of cairo surface and then paints to software?

>
Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.
cpp:351
> +    m_canvasPlatformLayer = platformLayer;
> +    m_canvasNeedsDisplay = true;
> +    if (client())
> +	   client()->notifyFlushRequired(this);

This lines exist inside the #if clause, why not take them outside the clause
altogether rather than have an #else?