[webkit-reviews] review denied: [Bug 104196] Adding New WebInputEvent type for IME events : [Attachment 177901] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has denied Aurimas
<aurimas at chromium.org>'s request for review:
Bug 104196: Adding New WebInputEvent type for IME events
https://bugs.webkit.org/show_bug.cgi?id=104196

Attachment 177901: Patch
https://bugs.webkit.org/attachment.cgi?id=177901&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=177901&action=review


> Source/WebKit/chromium/public/WebInputEvent.h:313
> +    // Caps on string lengths so we can make them static arrays and keep
> +    // them PODs.
> +    static const size_t textLengthCap = 400;
> +
> +    // |text| is the text that needs to be composed, committed, or replaced.

> +    WebUChar text[textLengthCap];

WebInputEvents are assumed to be POD and to be *cheap* to copy.  Making some be
800 bytes long seems contrary to this goal.