[webkit-reviews] review denied: [Bug 104186] Draw selection and cursor handles for touch based text editing : [Attachment 177861] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 5 21:49:50 PST 2012


James Robinson <jamesr at chromium.org> has denied Varun Jain
<varunjain at chromium.org>'s request for review:
Bug 104186: Draw selection and cursor handles for touch based text editing
https://bugs.webkit.org/show_bug.cgi?id=104186

Attachment 177861: Patch
https://bugs.webkit.org/attachment.cgi?id=177861&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
This is definitely not threadsafe - the members on TouchEvents can be mutated
on the main thread while the input handling logic is running on the compositor
thread.

I think we should keep input handling in WebCompositorInputHandlerImpl and
figure out how to get the information you need to that object in a thread-safe
and consistent way.


More information about the webkit-reviews mailing list