[webkit-reviews] review granted: [Bug 104206] [V8] Optimize v8StringOrNull() and v8StringOrUndefined() : [Attachment 177921] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 5 21:23:59 PST 2012


Adam Barth <abarth at webkit.org> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 104206: [V8] Optimize v8StringOrNull() and v8StringOrUndefined()
https://bugs.webkit.org/show_bug.cgi?id=104206

Attachment 177921: Patch
https://bugs.webkit.org/attachment.cgi?id=177921&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=177921&action=review


> Source/WebCore/bindings/v8/V8Binding.h:161
> +	   if (UNLIKELY(!isolate))
> +	       isolate = v8::Isolate::GetCurrent();

Some day we'll make isolate mandatory and remove all these branches.


More information about the webkit-reviews mailing list