[webkit-reviews] review denied: [Bug 104188] Implement OfflineAudioContext constructor : [Attachment 177905] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 5 20:16:00 PST 2012


Kentaro Hara <haraken at chromium.org> has denied Chris Rogers
<crogers at google.com>'s request for review:
Bug 104188: Implement OfflineAudioContext constructor
https://bugs.webkit.org/show_bug.cgi?id=104188

Attachment 177905: Patch
https://bugs.webkit.org/attachment.cgi?id=177905&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=177905&action=review


> Source/WebCore/Modules/webaudio/DOMWindowWebAudio.idl:33
>      [JSCustomGetter, V8EnabledAtRuntime] attribute AudioContextConstructor
webkitAudioContext;
> +    [JSCustomGetter, V8EnabledAtRuntime] attribute
OfflineAudioContextConstructor webkitOfflineAudioContext;

Can't you remove JSCustomGetter by improving CodeGeneratorJS.pm?


More information about the webkit-reviews mailing list