[webkit-reviews] review granted: [Bug 104203] [V8] Remove addImplicitReferencesForNodeWithEventListeners() : [Attachment 177899] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 5 18:39:59 PST 2012


Adam Barth <abarth at webkit.org> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 104203: [V8] Remove addImplicitReferencesForNodeWithEventListeners()
https://bugs.webkit.org/show_bug.cgi?id=104203

Attachment 177899: Patch
https://bugs.webkit.org/attachment.cgi?id=177899&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
There is a subtle difference here: Previously when someone was hold an event
listener function, they wouldn't hold the node it was attached to (because
AddImplicitReferences are one-way connections).  Now we'll hold the node as
well (because addToGroup is a two-way connection).  I can't see how that would
matter in practice.


More information about the webkit-reviews mailing list