[webkit-reviews] review granted: [Bug 102320] HTMLFormElement#requestAutocomplete() should require a user action : [Attachment 177898] if specified impl

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 5 18:28:59 PST 2012


Kent Tamura <tkent at chromium.org> has granted Dan Beam <dbeam at chromium.org>'s
request for review:
Bug 102320: HTMLFormElement#requestAutocomplete() should require a user action
https://bugs.webkit.org/show_bug.cgi?id=102320

Attachment 177898: if specified impl
https://bugs.webkit.org/attachment.cgi?id=177898&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=177898&action=review


> Source/WebCore/ChangeLog:14
> +	   * fast/forms/form-request-autocomplete.html:
> +	   
> +	   Added a test to ensure that dispatching a call to
HTMLFormElement#requestAutocomplete() in a setTimeout() (which will
> +	   never be a user gesture) always fails.

nit: This file is not a part of WebCore. So you don't need to follow the file
list style here.
"fast/forms/form-request-autocomplete.html is updated." is enough.


More information about the webkit-reviews mailing list