[webkit-reviews] review granted: [Bug 104136] WebKit2.def seems not regenerated when WebKit2.def.in is changed : [Attachment 177835] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <timothy_horton at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 104136: WebKit2.def seems not regenerated when WebKit2.def.in is changed
https://bugs.webkit.org/show_bug.cgi?id=104136

Attachment 177835: Patch
https://bugs.webkit.org/attachment.cgi?id=177835&action=review

------- Additional Comments from Tim Horton <timothy_horton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=177835&action=review


> Source/WebKit2/win/WebKit2ExportGenerator.vcproj:396
> +					CommandLine="REM Do not edit from the
Visual Studio IDE! Customize via a $(ProjectName)BuildCmd.cmd
file.&#x0D;&#x0A;if not exist
&quot;$(ProjectDir)$(ProjectName)BuildCmd.cmd&quot; exit
/b&#x0D;&#x0A;&#x0D;&#x0A;set
CONFIGURATIONBUILDDIR=$(ConfigurationBuildDir)&#x0D;&#x0A;set
CONFIGURATIONNAME=$(ConfigurationName)&#x0D;&#x0A;set
INPUTDIR=$(InputDir)&#x0D;&#x0A;set
INPUTFILENAME=$(InputFileName)&#x0D;&#x0A;set
INPUTPATH=$(InputPath)&#x0D;&#x0A;set INTDIR=$(IntDir)&#x0D;&#x0A;set
LIBRARYCONFIGSUFFIX=$(LibraryConfigSuffix)&#x0D;&#x0A;set
OUTDIR=$(OutDir)&#x0D;&#x0A;set PLATFORMNAME=$(PlatformName)&#x0D;&#x0A;set
PROJECTDIR=$(ProjectDir)&#x0D;&#x0A;set
PROJECTFILENAME=$(ProjectFileName)&#x0D;&#x0A;set
PROJECTNAME=$(ProjectName)&#x0D;&#x0A;set
PROJECTPATH=$(ProjectPath)&#x0D;&#x0A;set
SOLUTIONDIR=$(SolutionDir)&#x0D;&#x0A;set
SOLUTIONFILENAME=$(SolutionFileName)&#x0D;&#x0A;set
SOLUTIONNAME=$(SolutionName)&#x0D;&#x0A;set
SOLUTIONPATH=$(SolutionPath)&#x0D;&#x0A;set
TARGETDIR=$(TargetDir)&#x0D;&#x0A;set TARGETEXT=$(TargetExt)&#x0D;&#x0A;set
TARGETFILENAME=$(TargetFileName)&#x0D;&#x0A;set
TARGETPATH=$(TargetPath)&#x0D;&#x0A;set
WEBKITCONFIGSUFFIX=$(WebKitConfigSuffix)&#x0D;&#x0A;set
WEBKITDLLCONFIGSUFFIX=$(WebKitDLLConfigSuffix)&#x0D;&#x0A;&#x0D;&#x0A;REM If
any of the above variables didn&apos;t exist previously and&#x0D;&#x0A;REM were
set to an empty string, set will set the errorlevel to 1,&#x0D;&#x0A;REM which
will cause the project-specific script to think the build&#x0D;&#x0A;REM has
failed. This cmd /c call will clear the errorlevel.&#x0D;&#x0A;cmd
/c&#x0D;&#x0A;&#x0D;&#x0A;&quot;$(ProjectDir)$(ProjectName)BuildCmd.cmd&quot;&#
x0D;&#x0A;"

What's going on here?