[webkit-reviews] review requested: [Bug 104134] [Qt] QWebView uses the mobile style and doesn't follow Qt's style : [Attachment 177836] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 5 15:49:31 PST 2012


Pierre Rossi <pierre.rossi at gmail.com> has asked  for review:
Bug 104134: [Qt] QWebView uses the mobile style and doesn't follow Qt's style
https://bugs.webkit.org/show_bug.cgi?id=104134

Attachment 177836: Patch
https://bugs.webkit.org/attachment.cgi?id=177836&action=review

------- Additional Comments from Pierre Rossi <pierre.rossi at gmail.com>
I thought I'd move the call to initializeWebKitWidgets up in QWebPage's
constructor, but it's not going to be better in there because of the member
initialization, and so it would boil down to the same thing.
We are shooting ourselves in the foot by having QtTestBrowser always discard
the first WebPage it constructs, it contributed to keep this silly mistake
hidden until we merged it in Qt5... :(


More information about the webkit-reviews mailing list