[webkit-reviews] review denied: [Bug 96614] Need to clear exception in JSDictionary for operations that might have. : [Attachment 177806] Patch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has denied Michael Pruett
<michael at 68k.org>'s request for review:
Bug 96614: Need to clear exception in JSDictionary for operations that might
have.
https://bugs.webkit.org/show_bug.cgi?id=96614

Attachment 177806: Patch
https://bugs.webkit.org/attachment.cgi?id=177806&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=177806&action=review


> Source/WebCore/ChangeLog:13
> +	   JSDictionary should check whether the property being accessed in
get()
> +	   is an array before attempting to convert the value to an array.
> +
> +	   Previously calling get() with a result type of Vector<String> when
> +	   the named property could not be converted to an array would generate

> +	   an exception.

I guess you can fix JSDictionary::convertValue(ExecState* exec, JSValue value,
Vector<String>& result), instead of implementing yet another get().