[webkit-reviews] review granted: [Bug 104158] nrwt: collect all of the information about a run into a new RunDetails class : [Attachment 177815] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 104158: nrwt: collect all of the information about a run into a new
RunDetails class
https://bugs.webkit.org/show_bug.cgi?id=104158

Attachment 177815: Patch
https://bugs.webkit.org/attachment.cgi?id=177815&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=177815&action=review


>> Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:59
>> +class RunDetails(object):
> 
> I’m not sure if RunDetails is a descriptive name. "run" is an overloaded word
and can mean a lot of things.
> How about something like ManagerResults or simply LayoutTestResults?

Those are overloaded too. It's hard to think of a name that doesn't have this
problem. This class not used that widely, so I'm not too worried about this.

> Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:420
> +	   if options.lint_test_files:
> +	       return lint(port, options)

Really we should just move this into a different script entirely.
LintTestExpectations or whatever.