[webkit-reviews] review denied: [Bug 104162] [BlackBerry] Geolocation prompts won't respond to the correct geolocation object if the user opens two pages and respond in the reversed order : [Attachment 177821] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 5 13:56:56 PST 2012


Yong Li <yoli at rim.com> has denied otcheung at rim.com's request for review:
Bug 104162: [BlackBerry] Geolocation prompts won't respond to the correct
geolocation object if the user opens two pages and respond in the reversed
order
https://bugs.webkit.org/show_bug.cgi?id=104162

Attachment 177821: Patch
https://bugs.webkit.org/attachment.cgi?id=177821&action=review

------- Additional Comments from Yong Li <yoli at rim.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=177821&action=review


> Source/WebKit/blackberry/WebCoreSupport/GeolocationClientBlackBerry.cpp:165
> +    if (m_geolocationRequestMap.isEmpty())
> +	  
BlackBerry::Platform::GeolocationHandler::instance()->unregisterFromPermissionT
racking(this);

let's also do this in the dtor.


More information about the webkit-reviews mailing list