[webkit-reviews] review denied: [Bug 103116] REGRESSION(r127163): Content is offset to the right at rea.ru : [Attachment 177310] Patch

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has denied Robert Hogan <robert at webkit.org>'s
request for review:
Bug 103116: REGRESSION(r127163): Content is offset to the right at rea.ru
https://bugs.webkit.org/show_bug.cgi?id=103116

Attachment 177310: Patch
https://bugs.webkit.org/attachment.cgi?id=177310&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=177310&action=review


r-

> Source/WebCore/rendering/RenderBlockLineLayout.cpp:2134
> +	       m_block->setLogicalHeight(m_block->logicalHeight() -
marginOffset);

This is a very roundabout way of just setting the block back to its previous
logical height. I would prefer it if you just stored the block's logical height
in an oldLogicalHeight variable and set the block's height back to that
variable. I think that's more readable than this even though it adds one more
line of code.