[webkit-reviews] review denied: [Bug 101803] REGRESSION(r121789): Text not wrapping in presence of floating objects : [Attachment 176809] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 5 11:14:00 PST 2012


Dave Hyatt <hyatt at apple.com> has denied Robert Hogan <robert at webkit.org>'s
request for review:
Bug 101803: REGRESSION(r121789): Text not wrapping in presence of floating
objects
https://bugs.webkit.org/show_bug.cgi?id=101803

Attachment 176809: Patch
https://bugs.webkit.org/attachment.cgi?id=176809&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=176809&action=review


Just one question.

> Source/WebCore/rendering/RenderBlockLineLayout.cpp:140
> +    if (block->document()->inQuirksMode() && replacedHeight)
> +	   return replacedHeight;

Why only in quirks mode? Lines still grow to accommodate replaced elements in
all modes. I'm not really understanding this part.

Note the difference between NoQuirksMode and the other two modes is that in
NoQuirksMode, baseline-aligned images still have descent. Even if your
heuristic isn't good enough to account for this descent, the replacedHeight is
still relevant in all modes.


More information about the webkit-reviews mailing list