[webkit-reviews] review granted: [Bug 104113] [EFL][WK2] Context clients should unregister themselves when destroyed : [Attachment 177726] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 5 04:30:50 PST 2012


Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Christophe Dumez
<christophe.dumez at intel.com>'s request for review:
Bug 104113: [EFL][WK2] Context clients should unregister themselves when
destroyed
https://bugs.webkit.org/show_bug.cgi?id=104113

Attachment 177726: Patch
https://bugs.webkit.org/attachment.cgi?id=177726&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=177726&action=review


> Source/WebKit2/UIProcess/efl/ContextHistoryClientEfl.cpp:137
> +    m_context->initializeHistoryClient(0);

hmm maybe we should rename to not be called initialize then, and use
setHistoryClient


More information about the webkit-reviews mailing list