[webkit-reviews] review canceled: [Bug 104108] Web Inspector: Title of "Record Timeline" status button on "Timeline Panel" should be toggled upon the recording state : [Attachment 177715] Patch

[bugzilla-daemon at webkit.org]

Alexander Pavlov (apavlov) <apavlov at chromium.org> has canceled Sankeerth V S
<sankeerth.vs at samsung.com>'s request for review:
Bug 104108: Web Inspector: Title of "Record Timeline" status button on
"Timeline Panel" should be toggled upon the recording state
https://bugs.webkit.org/show_bug.cgi?id=104108

Attachment 177715: Patch
https://bugs.webkit.org/attachment.cgi?id=177715&action=review

------- Additional Comments from Alexander Pavlov (apavlov)
<apavlov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=177715&action=review


> Source/WebCore/ChangeLog:4
> +	   Panel" should be toggled upon the recording state.

I'd put it as "...should reflect the recording state."

> Source/WebCore/inspector/front-end/TimelinePanel.js:556
> +	       this.toggleTimelineButton.title = WebInspector.UIString("Stop");


The previous line looks like a more appropriate place for this line, since
starting the record and toggling the title are logically related, and sending
the metrics event is related to the entire sequence.