[webkit-reviews] review denied: [Bug 73671] [Qt] When turning off PluginsEnabled attribute then a QWebPage will still try to load plugins : [Attachment 177683] Updated patch based on feedback

[bugzilla-daemon at webkit.org]

Jocelyn Turcotte <jocelyn.turcotte at digia.com> has denied andy.shaw at digia.com's
request for review:
Bug 73671: [Qt] When turning off PluginsEnabled attribute then a QWebPage will
still try to load plugins
https://bugs.webkit.org/show_bug.cgi?id=73671

Attachment 177683: Updated patch based on feedback
https://bugs.webkit.org/attachment.cgi?id=177683&action=review

------- Additional Comments from Jocelyn Turcotte <jocelyn.turcotte at digia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=177683&action=review


> Source/WebKit/qt/ChangeLog:6
> +	   database for installed plugins.
> +
> +	   https://bugs.webkit.org/show_bug.cgi?id=73671

Normally the summary have to be all on the first line, and the bug number on
the second:

	Check that plugin functionality is enabled before querying the database
for installed plugins.
	https://bugs.webkit.org/show_bug.cgi?id=73671

> Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp:1360
> -    if (PluginDatabase::installedPlugins()->isMIMETypeRegistered(mimeType))
> +    if (m_frame && arePluginsEnabled)

I think there is a part missing :)
And no need to check m_frame.